Add Query Store query-text search filter#390
Merged
Merged
Conversation
- QueryStoreFilter.QueryTextSearch + shared BuildQueryTextSearchPattern helper (sp_QuickieStore default semantics: trim, auto-wrap %, wildcards stay live) - Parameterized EXISTS predicate applied pre-TOP-N in all three Query Store SQL builders (flat, grouped-by-hash, grouped-by-module) - Desktop: Query Text option in the Search-by combo - MCP: additive query_text_search param on get_query_store_top - CLI: additive --query-text-search option - Tests: helper pattern matrix + ParseExecutionType backfill (22 new cases) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sp_QuickieStore's@query_text_searchdefault behavior (requested in [FEATURE] Query text search #389).get_query_store_top, and the CLIquery-storecommand.%when missing;%,_,[,]remain live LIKE wildcards (bracket escaping is a possible follow-up, matching@escape_brackets).Closes #389
Changes
QueryStoreFilter.QueryTextSearchproperty + sharedQueryStoreFilter.BuildQueryTextSearchPatternhelper (QueryStorePlan.cs); identical parameterizedEXISTSpredicate againstsys.query_store_query_textadded toFetchTopPlansAsyncand both grouped builders (QueryStoreService.cs,QueryStoreService.Grouped.cs). With the filter unset, generated SQL is byte-identical to before.QueryStoreGridControl.axaml,QueryStoreGridControl.Filters.cs).query_text_searchparameter onget_query_store_top(named to avoid colliding with the tool's existingquery_textoutput field).--query-text-searchoption.QueryTextSearchPatternTests.cs— full wrap/trim/wildcard/null matrix for the helper, plus backfilled coverage for the previously untestedParseExecutionType(22 new cases; 123 total pass).Test Plan
dotnet build PlanViewer.sln -c Debug— no new warningsdotnet test— 123/123 pass (101 existing + 22 new)--query-text-search Votesreturn different query sets (proving pre-TOP-N filtering); no-match input exits cleanly with "no data"; returned query verified to match via substring (DownVotes)planview query-store --helpshows the new option with wildcard semanticsGenerated with Claude Code