Skip to content

chore: Fallback to the Symfony XML configuration only at ^6.4.0#2450

Merged
norberttech merged 1 commit into
flow-php:1.xfrom
stloyd:chore/sf-migrate-xml-1
Jun 15, 2026
Merged

chore: Fallback to the Symfony XML configuration only at ^6.4.0#2450
norberttech merged 1 commit into
flow-php:1.xfrom
stloyd:chore/sf-migrate-xml-1

Conversation

@stloyd

@stloyd stloyd commented Jun 15, 2026

Copy link
Copy Markdown
Member

The previous change did not correctly handle cases with Symfony 8+, now the old format is enforced only on old Symfony.

Details

Failing tests: https://github.com/flow-php/flow/actions/runs/27538039321/job/81392383775#step:10:1

Running locally:

flow on  chore/sf-migrate-xml-1 [$!?] via 🐘 v8.4.20 via ❄️  impure (nix-shell) took 3s 
just test --filter=FlowPostgreSqlProfilerTest
tools/phpunit/vendor/bin/phpunit --filter=FlowPostgreSqlProfilerTest
PHPUnit 11.5.55 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.20
Configuration: /Users/stloyd/Documents/flow/phpunit.xml.dist

..........                                                        10 / 10 (100%)


Time: 00:01.767, Memory: 253.00 MB

OK (10 tests, 27 assertions)

Change Log


Added

Fixed

Changed

  • Fallback to the Symfony XML configuration only at `^6.4.0`

Removed

Deprecated

Security

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (b230d37) to head (be8e6b3).

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #2450      +/-   ##
============================================
- Coverage     85.11%   85.11%   -0.01%     
- Complexity        0    21161   +21161     
============================================
  Files          1599     1599              
  Lines         65334    65334              
============================================
- Hits          55612    55611       -1     
- Misses         9722     9723       +1     
Components Coverage Δ
etl 88.32% <ø> (ø)
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 85.03% <ø> (ø)
lib-types 90.06% <ø> (ø)
lib-parquet 70.10% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.38% <ø> (-0.45%) ⬇️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.58% <ø> (ø)
lib-telemetry 85.95% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 96.82% <ø> (ø)
bridge-monolog-telemetry 94.11% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 97.84% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 89.89% <ø> (ø)
bridge-symfony-http-foundation-telemetry 89.47% <ø> (ø)
bridge-symfony-filesystem-bundle 90.20% <ø> (ø)
bridge-symfony-filesystem-cache 98.14% <ø> (ø)
bridge-symfony-postgresql-bundle 93.83% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 80.80% <ø> (ø)
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 91.16% <ø> (ø)
adapter-doctrine 90.79% <ø> (ø)
adapter-elasticsearch 92.07% <ø> (ø)
adapter-google-sheet 99.18% <ø> (ø)
adapter-http 72.34% <ø> (ø)
adapter-json 88.63% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 77.70% <ø> (ø)
adapter-text 74.13% <ø> (ø)
adapter-xml 83.40% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.21% <ø> (ø)
adapter-postgresql 91.11% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 80.08% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stloyd stloyd marked this pull request as ready for review June 15, 2026 11:47
@stloyd stloyd requested a review from norberttech as a code owner June 15, 2026 11:47
@norberttech norberttech merged commit 46eebfc into flow-php:1.x Jun 15, 2026
44 checks passed
@stloyd stloyd deleted the chore/sf-migrate-xml-1 branch June 15, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants