[shared_preferences] Add integration tests based on upstream v2.5.5#1047
Open
seungsoo47 wants to merge 1 commit into
Open
[shared_preferences] Add integration tests based on upstream v2.5.5#1047seungsoo47 wants to merge 1 commit into
seungsoo47 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds 12 integration test cases for the legacy-to-async migration utility in shared_preferences_test.dart and updates the changelog. The feedback suggests replacing the integer literal -0 with -1 in the test suite to avoid confusion, as -0 is equivalent to 0 for integers in Dart.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Port the upstream legacy-to-async migration-utility integration tests from shared_preferences v2.5.5, consolidated into the existing test file. For each of the no-prefix, setPrefix, setPrefix+allowList, and empty-prefix legacy configurations: - data is successfully transferred to new system - migrationCompleted key is set - re-running migration tool does not overwrite data The upstream platform-specific async option variants (Android/iOS/Linux/ Windows) collapse to the default options on Tizen and were omitted. The empty-prefix "re-running" case is skipped because the Tizen legacy and async stores share a single preference namespace (matching how upstream skips it on other shared-namespace platforms). Test-only change; recorded under a NEXT changelog entry without a version bump. Validated on a Raspberry Pi 4 device: 75 passed, 1 skipped, 0 failed.
seungsoo47
force-pushed
the
shared_preferences-add-integration-tests
branch
from
558a69d to
17d4e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the upstream legacy-to-async migration-utility integration tests from shared_preferences v2.5.5, consolidated into the existing test file. For each of the no-prefix, setPrefix, setPrefix+allowList, and empty-prefix legacy configurations:
The upstream platform-specific async option variants (Android/iOS/Linux/ Windows) collapse to the default options on Tizen and were omitted. The empty-prefix "re-running" case is skipped because the Tizen legacy and async stores share a single preference namespace (matching how upstream skips it on other shared-namespace platforms).
Test-only change; recorded under a NEXT changelog entry without a version bump. Validated on a Raspberry Pi 4 device: 75 passed, 1 skipped, 0 failed.