[video_player_videohole] Remove Ecore API#1048
Conversation
- Replace ecore_pipe with GLib GMainContext for thread-safe event dispatching - Remove dependency on Ecore library for main loop event handling - Retain EcoreWl2WindowProxy for window geometry queries (dynamically loaded) Co-Authored-By: Cline SR
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the Ecore API with GLib for event dispatching and license request processing in DrmManager and VideoPlayer, and bumps the package version to 0.5.9. The review feedback highlights critical concurrency issues, including holding mutexes during long-running operations and external callbacks, which can cause deadlocks, as well as potential data races on event_sink_ due to checking it outside of the mutex lock in PushEvent and SendError.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Main changes:
Co-Authored-By: Cline SR