get: harden repos.json save/load against empty/corrupted state#33
Open
timkicker wants to merge 1 commit into
Open
get: harden
repos.json save/load against empty/corrupted state#33timkicker wants to merge 1 commit into
timkicker wants to merge 1 commit into
Conversation
state saveRepos writes via tmp + atomic rename with fsync, so a crash mid-write can't truncate the file. loadRepos regenerates the default when the parsed repos array is empty or the JSON is corrupted; on parse failure the bad file is moved to repos.json.bad instead of being overwritten. Drive-by: missing <cstdint> include in Utils.hpp. Closes fortheusers/hb-appstore#163
Member
|
Thanks! Looks good on quick readthrough. I'm cool to merge this as part of other HBAS updates; we can check for platform compatibility bugs as part of on-device testing for next HBAS release and backport changes if necessary. @vgmoose your call. |
Closed
Member
|
I'm actually a little cagey on this just because of how file streams and rename operations work (or, don't work) on homebrew platforms. Can we accomplish something similar without a tmp file first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fortheusers/hb-appstore#163.
saveReposnow writes via tmp + atomic rename with fsync andloadReposregenerates the default for empty/corrupted files (with the bad file preserved as repos.json.bad).