Skip to content

ref(mcp): Add package to the typing group#6727

Merged
alexander-alderman-webb merged 11 commits into
masterfrom
webb/mcp/types
Jul 6, 2026
Merged

ref(mcp): Add package to the typing group#6727
alexander-alderman-webb merged 11 commits into
masterfrom
webb/mcp/types

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Add mcp to the typing dependencies and resolve errors.

sentry_sdk/integrations/mcp.py:27: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/mcp.py:28: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/mcp.py:33: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/mcp.py:33: error: Module "mcp.server.lowlevel.server" has no attribute "request_ctx"  [attr-defined]
sentry_sdk/integrations/mcp.py:33: note: Error code "attr-defined" not covered by "type: ignore[import-not-found]" comment
sentry_sdk/integrations/mcp.py:46: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/mcp.py:50: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/mcp.py:50: error: Incompatible types in assignment (expression has type "None", variable has type "type[ServerRequestContext[LifespanContextT, RequestT]]")  [assignment]
sentry_sdk/integrations/mcp.py:52: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/mcp.py:52: error: Incompatible types in assignment (expression has type "None", variable has type "type[ServerRequestContext[LifespanContextT, RequestT]]")  [assignment]
sentry_sdk/integrations/mcp.py:714: error: "type[Server[LifespanResultT]]" has no attribute "call_tool"  [attr-defined]
sentry_sdk/integrations/mcp.py:724: error: "type[Server[LifespanResultT]]" has no attribute "call_tool"  [attr-defined]
sentry_sdk/integrations/mcp.py:727: error: "type[Server[LifespanResultT]]" has no attribute "get_prompt"  [attr-defined]
sentry_sdk/integrations/mcp.py:737: error: "type[Server[LifespanResultT]]" has no attribute "get_prompt"  [attr-defined]
sentry_sdk/integrations/mcp.py:740: error: "type[Server[LifespanResultT]]" has no attribute "read_resource"  [attr-defined]
sentry_sdk/integrations/mcp.py:750: error: "type[Server[LifespanResultT]]" has no attribute "read_resource"  [attr-defined]
sentry_sdk/integrations/mcp.py:793: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/mcp.py:813: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/mcp.py:832: error: Cannot assign to a method  [method-assign]

Issues

Reminders

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90003 passed | ⏭️ 6298 skipped | Total: 96301 | Pass Rate: 93.46% | Execution Time: 316m 53s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 73.33%. Project has 2438 uncovered lines.
✅ Project coverage is 89.77%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/mcp.py 73.33% ⚠️ 4 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.74%    89.77%    +0.03%
==========================================
  Files          192       192         —
  Lines        23823     23823         —
  Branches      8226      8226         —
==========================================
+ Hits         21378     21385        +7
- Misses        2445      2438        -7
- Partials      1349      1348        -1

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the base branch from master to webb/pydantic July 2, 2026 11:24
Base automatically changed from webb/pydantic to master July 6, 2026 07:06
@alexander-alderman-webb alexander-alderman-webb changed the title ref(mcp): Add package to typing group ref(mcp): Add package to the typing group Jul 6, 2026
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review July 6, 2026 07:36
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner July 6, 2026 07:36
@alexander-alderman-webb alexander-alderman-webb merged commit afaa48f into master Jul 6, 2026
141 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/mcp/types branch July 6, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants