Re-enable expensive tests in Windows CI#6281
Open
dscho wants to merge 1 commit into
Open
Conversation
Now that -rc0 is out and no longer adding pressure, let's _actually_ re-enable the expensive tests on Windows. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When -rc0 was pressing and I had too many things breaking (after having a beautifully passing CI of the branch thicket rebased on top of upstream's
mastermere hours before -rc0 merged tons of big stuff), I tried to disable the expensive tests that break e.g. macOS CI jobs (because of inadequate timeouts, at least in one instance).In my frustration, I forgot to revert a change Copilot had suggested (to skip this on pushes to
main). Since -rc0 was tested in a PR (#6278), that bug didn't matter, but it's still better to fix that bug than to leave it in place.