Increase Security Guard turn budget and harden integration container build reliability#4435
Conversation
There was a problem hiding this comment.
Pull request overview
This PR increases the Claude engine “turn budget” for the Security Guard workflow to avoid error_max_turns termination during multi-step review flows, while keeping the workflow’s scope and checks unchanged.
Changes:
- Bumped
engine.max-turnsin the source Security Guard workflow from4to6. - Updated the generated lock workflow to pass
--max-turns 6and setGH_AW_MAX_TURNS: 6. - Adjusted CI assertions to validate the updated turn limit in both source and lock artifacts.
Show a summary per file
| File | Description |
|---|---|
scripts/ci/security-guard-workflow.test.ts |
Updates workflow config expectations to assert max-turns: 6 / --max-turns 6 / GH_AW_MAX_TURNS: 6. |
.github/workflows/security-guard.md |
Increases the Claude engine max-turns to 6 in the source workflow. |
.github/workflows/security-guard.lock.yml |
Keeps the compiled lock workflow in sync by updating the harness --max-turns flag and GH_AW_MAX_TURNS. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot fix this failing ci check https://github.com/github/gh-aw-firewall/actions/runs/27066771243/job/79889253617?pr=4435 |
|
Smoke Test Results: Copilot BYOK AOAI Entra
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall status: PASS cc Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "api.openai.com"See Network Configuration for more information.
|
Fixed in |
Smoke Test: Claude Engine
Result: PASS
|
🔬 Smoke Test Results
PR: Increase Security Guard turn budget and harden integration container build reliability Overall: PASS
|
|
Smoke test results Merged PRs:
Overall status: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🔥 Smoke Test: Copilot BYOK (Direct) ModeRunning in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com
Pre-fetched PR (MCP, latest merged): #4434 — Fix Smoke Model Policy false failure from stale api-proxy log path Overall: PASS ✅ cc author & assignees:
|
|
Smoke test results: Gemini engine validation failed on MCP and connectivity tests. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Security Guard runs on
copilot/allowed-and-disallowed-modelswere failing in theagentjob because the Claude harness hiterror_max_turns(Reached maximum number of turns (4)) before completion. This updates the workflow turn budget so the guard can complete multi-step review flows without changing review scope.Additionally, this PR addresses a failing Integration Tests check caused by a transient Docker Hub timeout during local image builds in
Container & Ops Tests.Workflow runtime budget
.github/workflows/security-guard.mdmax-turns: 4→max-turns: 6Compiled lock workflow parity
.github/workflows/security-guard.lock.yml--max-turns 6GH_AW_MAX_TURNS: 6Regression guard for workflow config
scripts/ci/security-guard-workflow.test.ts6turns in both source and lock artifacts.Integration workflow resilience
Container & Ops Tests:.github/workflows/test-integration-suite.ymlsquidandagentlocal images to reduce failures from transient registry/network timeouts.