fix(react): pickup date range respects lead time (prep_time)#1393
Open
agupta17-godaddy wants to merge 1 commit into
Open
fix(react): pickup date range respects lead time (prep_time)#1393agupta17-godaddy wants to merge 1 commit into
agupta17-godaddy wants to merge 1 commit into
Conversation
The date picker now accounts for leadTime when computing selectable dates: - Start date = first available date after current_time + leadTime - End date = start date + pickupWindowInDays (advance window from first bookable date) - Fixed double-zoning bug in findFirstAvailablePickupDate that caused incorrect day-of-week on non-UTC machines (returns raw date instead of pre-zoned date so generatePickupTimeSlots can zone it once) - Use formatTz for pickupDate form values to ensure store timezone is used Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The date picker in local pickup checkout now accounts for the store's
leadTime(prep_time) when determining selectable dates.Key Changes:
current_time + leadTime(previously today)pickupWindowInDays(previously today + window)findFirstAvailablePickupDatethat caused incorrect day-of-week on non-UTC machinesformatTzfor pickupDate form values to ensure store timezone is usedFiles Changed:
packages/react/src/components/checkout/pickup/utils/generate-pickup-time-slots.tspackages/react/src/components/checkout/pickup/local-pickup.tsxTest Plan
pnpm --filter @godaddy/react testCloses #VNEXT-80686
Made with Cursor