feat: add additional scene delegate methods#242
Draft
daymxn wants to merge 7 commits into
Draft
Conversation
Member
|
/gemini review |
ncooke3
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per b/532968854,
This adds functionality to
GULSceneDelegateSwizzlerto properly proxy bothscene:willConnectToSession:options:andscene:continueUserActivity:, as the alternatives were already being proxied within the app delegate swizzler.Tests have also been added for these. Note that these methods check if the developer already had an implementation, and call it directly instead of handling it in those cases. This should ensure that existing implementations aren't broken by this change.
This PR also removes a small bit of redundant code in the
scene:openURLContexts:proxy method. The code was previously explicitly checking protocol conformance and casts inside the interceptor block, but this was already being performed by the parentnotifyInterceptorsWithMethodSelectormethod, so it's a bit redundant.Furthermore, this PR adds a bit of code that will also attempt to proxy existing scene delegates that were already connected when our code started. It may not be an issue, but with the lifecycle nuances of newer Swift ecosystems (especially around Scenes), I thought it better safe than sorry; as it could also address any potential edge-cases.