Remove null checks where null is impossible.#5890
Merged
Merged
Conversation
Jetski keeps wanting to insert such checks in unknown commit on the result of `getSymbol` overloads that never return `null`. Maybe this will help? Also, it's nice to simplify the code. Those changes come courtesy of IntelliJ. Also, in `SuppressionInfo`, move away from an `AtomicBoolean` pattern that I personally don't love in favor of an equivalent pattern using `var`, which I do love. PiperOrigin-RevId: 934978976
copybara-service
Bot
force-pushed
the
test_934509236
branch
from
e6b9c77 to
8aaf514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove null checks where
nullis impossible.Jetski keeps wanting to insert such checks in unknown commit on the result of
getSymboloverloads that never returnnull. Maybe this will help? Also, it's nice to simplify the code.Those changes come courtesy of IntelliJ.
Also, in
SuppressionInfo, move away from anAtomicBooleanpattern that I personally don't love in favor of an equivalent pattern usingvar, which I do love.