Allow == on private (and "privately constructible") classes that we can prove have no equals overrides in their class hierarchy.#5891
Merged
Conversation
… can prove have no `equals` overrides in their class hierarchy. (a further counterproposal to a116aaf) (I'm ignoring the possibility that someone might generate subclasses that _do_ override `equals` (when the superclass did not already) at runtime.) This helps with #5865. PiperOrigin-RevId: 935049836
copybara-service
Bot
force-pushed
the
test_931296006
branch
from
d0d3a31 to
b653855
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
==on private (and "privately constructible") classes that we can prove have noequalsoverrides in their class hierarchy.(a further counterproposal to a116aaf)
(I'm ignoring the possibility that someone might generate subclasses that do override
equals(when the superclass did not already) at runtime.)This helps with #5865.