Skip to content

Extra WGSL validation for @align#4667

Merged
alan-baker merged 3 commits into
gpuweb:mainfrom
alan-baker:align-extra-val
Jun 20, 2026
Merged

Extra WGSL validation for @align#4667
alan-baker merged 3 commits into
gpuweb:mainfrom
alan-baker:align-extra-val

Conversation

@alan-baker

Copy link
Copy Markdown
Contributor
  • Cover no value decl usage
  • Cover more address spaces
  • Cover other types of decls

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

* Cover no value decl usage
* Cover more address spaces
* Cover other types of decls
@alan-baker alan-baker requested review from dj2, dneto0 and jrprice June 18, 2026 18:19
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Results for build job (at 4db18d6):

-webgpu:shader,validation,shader_io,align:required_alignment:* - 256 cases, 256 subcases (~1/case)
+webgpu:shader,validation,shader_io,align:required_alignment:* - 36 cases, 1128 subcases (~31/case)
-TOTAL: 283229 cases, 2325040 subcases
+TOTAL: 283009 cases, 2325912 subcases

Comment thread src/webgpu/shader/validation/shader_io/align.spec.ts Outdated
@alan-baker alan-baker merged commit f529c5a into gpuweb:main Jun 20, 2026
1 check passed
@alan-baker alan-baker deleted the align-extra-val branch June 20, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants