feat(rust-sdk): auto-install rustup targets on target=; update hm init template + docstrings#146
Merged
Merged
Conversation
…opt-out), at parity
Replace the legacy toolchain() + explicit build/test/clippy/fmt tuple with the rust.project().ci() one-call DAG. Strengthen the test to assert the new API and reject the old one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-compile, made trivial
Passing
target=<triple>to any compiling method (build/test/doctest/clippy/doc) now auto-prependsrustup target add <triple> &&to the emitted command, so cross builds work without the manual rustup dance:build(target="wasm32-unknown-unknown")emits… && rustup target add wasm32-unknown-unknown && cargo build --target wasm32-unknown-unknown --locked. Opt out withadd_target=False(TS:addTarget: false) for runner images that pre-bake targets.The install lands in the compiling leaf (idempotent) because steps fork from the
warmupsnapshot, which only has the host target — so the target must be present at/above the consuming step.fmtis untouched (it doesn't compile and takes notarget=). Target values are shell-quoted. Python + TS at parity; golden parity test updated.Neglected follow-ups from #143
hm initRust template now scaffoldsrust.project().ci()(not the legacytoolchain()+ explicit steps). Init test strengthened to assert the new API.RustToolchain/RustProjectaction method, so the auto-generated pipeline-SDK reference docs describe the real surface (incl. the newtarget=auto-install).hm inittemplate and regenerate the docs in the same change.The regenerated
rust.mdxlives in the simci (parent) repo and is committed there with the gitlink bump.Tests
cmd_inittests pass (incl. roundtrip render of the new template).