fix(ci): drop removed default_image kwarg from dogfood pipeline#147
Merged
Conversation
The `@hm.pipeline` decorator no longer accepts `default_image` — root
steps auto-stamp `ubuntu:24.04`. The committed `.hm/ci.py` still passed
it, so prod's server-side render rejected it:
TypeError: pipeline() got an unexpected keyword argument 'default_image'
failing every `ci` build at render time (`render_failed`, exit 1).
Remove the kwarg. The `:apt: base` root now auto-stamps `ubuntu:24.04`
(verified via dump_registry_json), so build behavior is unchanged.
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
cibuild in prod fails at render time:The
@hm.pipelinedecorator form no longer acceptsdefault_image(only the factory form ever did, and root steps now auto-stampubuntu:24.04). But the committed.hm/ci.pystill passeddefault_image="ubuntu:24.04". Since prod renders pipelines server-side against its baked DSL, the stale kwarg blows up with a raw Python traceback and the whole build is markedrender_failed.Fix
Drop the kwarg. The
:apt: baseroot auto-stampsubuntu:24.04, so build behavior is unchanged.Verified via
dump_registry_json()— root:apt: baserenders withimage=ubuntu:24.04; children inherit through the snapshot-fork lineage (image=None, as before).