chore: replaces idp realm url#580
Open
v3nant wants to merge 1 commit into
Open
Conversation
v3nant
force-pushed
the
chore/migrate-realm-url
branch
from
c303c22 to
7c11d4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRealmUrl()insrc/service/auth-config.svc.tsby replacing the separateNES_KC_BASEandNES_KC_REALMenv var overrides with a single hardcoded default URLNES_KC_BASEandNES_KC_REALMenv var support — the full realm URL is now a single constant (DEFAULT_REALM_URL) rather than being assembled from partsOAUTH_CONNECT_URLoverride is preserved for cases that need a non-default endpointTest plan
https://auth.herodevs.com/idp/realms/universe/protocol/openid-connectOAUTH_CONNECT_URLto a custom URL — confirm that value is used insteadNES_KC_BASE/NES_KC_REALMare no longer referenced anywhere in the codebase