Skip to content

fix lwjgl3 dependencies: add windows-arm64 and remove 32bit#2882

Merged
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:windowsarm64
Jun 19, 2026
Merged

fix lwjgl3 dependencies: add windows-arm64 and remove 32bit#2882
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:windowsarm64

Conversation

@riccardobl

@riccardobl riccardobl commented Jun 18, 2026

Copy link
Copy Markdown
Member

partially fixes #1853
tests are still missing, but out of scope of this pr, since we test only on linux and android, doing tests elsewhere needs a specialized harness and dedicated PR

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the jme3-lwjgl3/build.gradle file to add natives-windows-arm64 native dependencies for various LWJGL3 libraries, including base, jemalloc, opengl, openal, opengles, and sdl. Additionally, it removes the natives-windows-x86 and natives-linux-arm32 classifiers from the opengles dependency. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@riccardobl riccardobl merged commit d15e32e into jMonkeyEngine:master Jun 19, 2026
12 checks passed
@stephengold

Copy link
Copy Markdown
Member

Thanks, Riccardo!

we test only on linux and android

The automated test matrix already includes "Build on windows jdk25" and "Build on mac jdk25". That script could easily be adapted to also test Windows-on-ARM and/or MacOS-on-Intel:

os: [ubuntu-latest, windows-latest, macOS-latest]

@riccardobl

riccardobl commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Thanks, Riccardo!

we test only on linux and android

The automated test matrix already includes "Build on windows jdk25" and "Build on mac jdk25". That script could easily be adapted to also test Windows-on-ARM and/or MacOS-on-Intel:

os: [ubuntu-latest, windows-latest, macOS-latest]

Those are the unit tests, afaik. We need to run the screenshot test to properly test the lwjgl3 backend, and for that we need to port the software rendering environment to windows somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing lwjgl3 natives for windows arm64

2 participants