fix lwjgl3 dependencies: add windows-arm64 and remove 32bit#2882
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the jme3-lwjgl3/build.gradle file to add natives-windows-arm64 native dependencies for various LWJGL3 libraries, including base, jemalloc, opengl, openal, opengles, and sdl. Additionally, it removes the natives-windows-x86 and natives-linux-arm32 classifiers from the opengles dependency. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Thanks, Riccardo!
The automated test matrix already includes "Build on windows jdk25" and "Build on mac jdk25". That script could easily be adapted to also test Windows-on-ARM and/or MacOS-on-Intel: jmonkeyengine/.github/workflows/main.yml Line 228 in d15e32e |
Those are the unit tests, afaik. We need to run the screenshot test to properly test the lwjgl3 backend, and for that we need to port the software rendering environment to windows somehow. |
partially fixes #1853
tests are still missing, but out of scope of this pr, since we test only on linux and android, doing tests elsewhere needs a specialized harness and dedicated PR