Skip to content

fix/1043 empty array handling in filter expressions #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kavyaNamballa wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix/1043 empty array handling in filter expressions #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0062eb
fix/1043 empty array handling in filter expressions
kavyaNamballa Jun 24, 2025
5043708
added test for the empty array handling fix
kavyaNamballa Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion json-path/src/main/java/com/jayway/jsonpath/internal/filter/ValueNodes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,14 @@ public ValueNode evaluate(Predicate.PredicateContext ctx) {
try {
Configuration c = Configuration.builder().jsonProvider(ctx.configuration().jsonProvider()).options(Option.REQUIRE_PROPERTIES).build();
Object result = path.evaluate(ctx.item(), ctx.root(), c).getValue(false);
return result == JsonProvider.UNDEFINED ? FALSE : TRUE;
if (result == JsonProvider.UNDEFINED) {
return FALSE;
}
// If the result is an empty array, return FALSE for exists checks
if (ctx.configuration().jsonProvider().isArray(result) && ctx.configuration().jsonProvider().length(result) == 0) {
return FALSE;
}
return TRUE;
} catch (PathNotFoundException e) {
return FALSE;
}
Expand Down
26 changes: 26 additions & 0 deletions json-path/src/test/java/com/jayway/jsonpath/ExistsCheckTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.jayway.jsonpath;

import org.junit.jupiter.api.Test;

import java.util.List;

import static org.assertj.core.api.Assertions.assertThat;

public class ExistsCheckTest extends BaseTest {

@Test
public void deep_products_exists_returns_only_store_b() {
String json = "[" +
"{\"id\":1,\"name\":\"Store A\",\"departments\":[{\"id\":10,\"name\":\"Electronics\",\"products\":[{\"id\":101,\"name\":\"TV\",\"in_stock\":true},{\"id\":102,\"name\":\"Laptop\",\"in_stock\":false}]},{\"id\":11,\"name\":\"Clothing\",\"products\":[{\"id\":201,\"name\":\"Shirt\",\"in_stock\":true},{\"id\":202,\"name\":\"Jeans\",\"in_stock\":true}]}]} ," +
"{\"id\":2,\"name\":\"Store B\",\"departments\":[{\"id\":12,\"name\":\"Grocery\",\"products\":[{\"id\":301,\"name\":\"Milk\",\"in_stock\":false},{\"id\":302,\"name\":\"Eggs\",\"in_stock\":true}]}]}" +
"]";

Object doc = Configuration.defaultConfiguration().jsonProvider().parse(json);

List<String> res1 = JsonPath.read(doc, "$[?(@..products[?(@.id==302)])].name");
assertThat(res1).containsExactly("Store B");

List<String> res2 = JsonPath.read(doc, "$[?(@.departments[?(@.products[?(@.id==302)])])].name");
assertThat(res2).containsExactly("Store B");
}
}