feat: add PodDisruptionBudget for vector aggregators with replicas > 1#229
Open
stigglor wants to merge 1 commit into
Open
feat: add PodDisruptionBudget for vector aggregators with replicas > 1#229stigglor wants to merge 1 commit into
stigglor wants to merge 1 commit into
Conversation
The operator now creates a PodDisruptionBudget for VectorAggregator and ClusterVectorAggregator deployments when spec.replicas is greater than 1. The budget keeps at most one pod unavailable during voluntary disruptions such as node drains. When an aggregator runs a single replica or is scaled back down, the operator removes any budget it previously created. Both aggregator types share the same controller, so one reconcile step covers them. Operator RBAC gains permission to manage poddisruptionbudgets in the policy API group, applied in the kubebuilder markers, the generated role, and the helm clusterrole. Closes kaasops#228
warwick-mitchell
approved these changes
Jun 25, 2026
Contributor
|
Hi, and thanks for the contribution! The HPA autoscaling work (#230) just merged, so this PR now conflicts with main and needs a rebase. Most of it is mechanical (shared RBAC and the aggregator controller wiring). One real change beyond the textual conflicts: spec.replicas is now a *int32 (it was int32), so the replicas <= 1 check in pdb.go needs a small update for the pointer. One more thing worth handling: when autoscaling is on, the replica count is set by the HPA, not by spec.replicas, so that same check can skip the PDB for an aggregator that is actually running several replicas. Happy to help with that part if useful. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator now creates a PodDisruptionBudget for VectorAggregator and ClusterVectorAggregator deployments when spec.replicas is greater than 1. The budget keeps at most one pod unavailable during voluntary disruptions such as node drains. When an aggregator runs a single replica or is scaled back down, the operator removes any budget it previously created.
Both aggregator types share the same controller, so one reconcile step covers them. Operator RBAC gains permission to manage poddisruptionbudgets in the policy API group, applied in the kubebuilder markers, the generated role, and the helm clusterrole.
Closes #228