feat(helm/kagent): support deployment annotations#2143
Open
anthonyhaussman wants to merge 2 commits into
Open
Conversation
anthonyhaussman
requested review from
EItanya,
ilackarms,
iplay88keys,
jmhbh,
supreme-gg-gg and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Helm values and template wiring to support Deployment-level annotations for the kagent controller and UI, with both a global annotations map and per-component settings.
Changes:
- Introduces a new top-level
annotationsmap invalues.yamlintended to apply to all Deployment resources. - Adds
controller.annotationsandui.annotationsvalues and wires them into the respective Deployment templates. - Extends Helm unit tests to validate annotations behavior for controller and UI deployments.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/kagent/values.yaml | Adds global and component-specific values for Deployment-level annotations. |
| helm/kagent/templates/ui-deployment.yaml | Renders UI Deployment metadata.annotations based on values. |
| helm/kagent/templates/controller-deployment.yaml | Renders controller Deployment metadata.annotations based on values. |
| helm/kagent/tests/ui-deployment_test.yaml | Adds tests for UI Deployment annotations behavior. |
| helm/kagent/tests/controller-deployment_test.yaml | Adds tests for controller Deployment annotations behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add support for deployment-level annotations on the controller and UI deployments. Allows configuring a global annotations map that applies to all deployments, as well as component-specific overrides via controller.annotations and ui.annotations. Signed-off-by: Anthony Hausman <anthony.hausman@backmarket.com>
Use mergeOverwrite to merge global annotations and component-specific annotations instead of either/or selection. Add tests to verify global keys are preserved. Signed-off-by: Anthony Hausman <anthony.hausman@backmarket.com>
anthonyhaussman
force-pushed
the
feat/helm-kagent-deployment-annotations
branch
from
027223b to
5814918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for deployment-level annotations on the controller and UI deployments.
Allows configuring a global annotations map that applies to all deployments, as well as component-specific overrides via
controller.annotationsandui.annotations.