Add raw GET methods for unparsed Kill Bill responses#118
Open
tungleduyxyz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds an API surface to fetch Kill Bill endpoints while returning the raw (unparsed) response body, enabling callers to bypass JSON-to-model parsing when needed.
Changes:
- Add
KillBillClient::Model::Resource.raw_getto returnresponse.bodydirectly fromKillBillClient::API.get. - Add
KillBillClient::Model::Subscription.find_raw_by_idas a raw-body counterpart tofind_by_id. - Add RSpec coverage validating passthrough behavior, default arguments, and that model parsing is not invoked.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/killbill_client/raw_response_spec.rb | Adds specs for Resource.raw_get and Subscription.find_raw_by_id raw-body behavior and error propagation. |
| lib/killbill_client/models/subscription.rb | Adds Subscription.find_raw_by_id which delegates to raw_get and returns the raw response body. |
| lib/killbill_client/models/resource.rb | Adds Resource.raw_get that performs a GET and returns response.body without parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+41
| api_response = double('Net::HTTPResponse', :body => '{"className":"NoSuchElementException"}') | ||
| response_error = KillBillClient::API::ResponseError.new(api_response, 404) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related : killbill/killbill-admin-ui#611
Summary
Resource.raw_getto fetch endpoints and return the raw response body without model parsingSubscription.find_raw_by_idas a raw-response counterpart tofind_by_idTest plan
bundle exec rspec spec/killbill_client/raw_response_spec.rb