Proofreading chapter 2#4487
Conversation
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
mpgreaves
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
dosubot
Bot
added
the
size:L
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR proofreads and rephrases Chapter 2 (“Concepts”) of the kpt book, aiming to improve clarity and readability of the documentation content.
Changes:
- Reworded multiple sections for improved grammar and readability.
- Restructured several paragraphs into bullet/numbered lists and expanded some explanations.
- Updated wording and formatting across the “Packages”, “Workflows”, and “Functions” sections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review: not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review: not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @mpgreaves, just a heads-up for future commits to please follow contributing.md. It helps keep the logs structured and clean. Thanks for the contribution! |
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review:not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
There was a problem hiding this comment.
looks good just a few minor things maybe to patch in before merging
| - **`kpt.dev/bfs-rendering`**: When set to `"true"`, this annotation renders the package hierarchy in breadth-first order, instead of the default depth-first | ||
| post-order. | ||
| - **`kpt.dev/save-on-render-failure`**: When set to `"true"`, this annotation saves partially rendered resources to disk, even when rendering fails, instead of reverting all changes. This is particularly useful for debugging render failures and is essential for programmatic package rendering scenarios, where preserving partial progress is valuable. |
There was a problem hiding this comment.
as we mention subpackages just above this the annotations here should probably also clarify if they operate and the subpackage level when defined in its parent package or if its isolated on a per package basis etc
There was a problem hiding this comment.
Correct, the only problem that I do not know the answer :)
Will ask on Slack.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
No description provided.