Add fees value for recent payment details#4674
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
|
I re-examined the full data flow and all construction/match sites:
No issues found. |
| bool, | ||
| ) -> (Option<MonitorUpdateCompletionAction>, Option<RAAMonitorUpdateBlockingAction>), | ||
| ) | ||
| -> (Option<MonitorUpdateCompletionAction>, Option<RAAMonitorUpdateBlockingAction>), |
There was a problem hiding this comment.
These should go away if you format with 1.75
| /// Total routing fees paid for this payment, as also reported via the `fee_paid_msat` | ||
| /// field of [`Event::PaymentSent`]. | ||
| /// | ||
| /// `None` for payments fulfilled before this field was introduced. |
There was a problem hiding this comment.
We should note the specific version
There was a problem hiding this comment.
added specific version (0.3.0)
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Introduce fields `pending_fee_msat` for `RecentPaymentDetails::Pending` and `fee_paid_msat` for `RecentPaymentDetails::Fulfilled`.
randomlogin
force-pushed
the
expose-fees-in-payment-details
branch
from
95ece4a to
af19ed5
Compare
|
@TheBlueMatt not sure if you want this backported, it's just adding a new field. |
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
5 participants
Previously it was not possible to obtain fees of pending/fulfilled payments.
Also we can add and populate the fee field for
RecentPaymentDetails::Abandoned, but I doubt that it is useful, as the payment was not made.I ran cargo fmt, so unrelated parts of code were changed.
Removed unnecessary clarification "in msat" for
total_msatfield.