chore: support new security control (IN-1170)#4220
Open
joanagmaia wants to merge 1 commit into
Open
Conversation
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Tinybird security control→category mapping used by the security widgets/pipes by adding the new OSPS control OSPS-BR-07 under the “Build and Release” category in both relevant pipes.
Changes:
- Added
('OSPS-BR-07', 'Build and Release', 2)to the Build and Release control list insecurity_and_best_practices.pipe. - Added the same mapping entry to
security_deduplicated_merged_copy_pipe.pipeto keep both pipes consistent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/libs/tinybird/pipes/security_and_best_practices.pipe | Adds OSPS-BR-07 to the Build and Release category mapping used by the security widget pipe. |
| services/libs/tinybird/pipes/security_deduplicated_merged_copy_pipe.pipe | Adds OSPS-BR-07 to the equivalent mapping to keep deduplicated/merged security data aligned. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new entry for the
Build and Releasecategory in both thesecurity_and_best_practices.pipeandsecurity_deduplicated_merged_copy_pipe.pipefiles. The new entry,OSPS-BR-07, is now included alongside the existing build and release items.Additions to the Build and Release category:
('OSPS-BR-07', 'Build and Release', 2)to the list of entries insecurity_and_best_practices.pipe.('OSPS-BR-07', 'Build and Release', 2)to the list of entries insecurity_deduplicated_merged_copy_pipe.pipe.Note
Low Risk
Single-line additions to static OSPS control lists with no query or business-logic changes; risk is only if upstream evaluations use a different control ID than
OSPS-BR-07.Overview
Registers the new OSPS Build and Release control
OSPS-BR-07in the sharedcontrolId→ category lookup used by Tinybird security pipes.The same tuple
('OSPS-BR-07', 'Build and Release', 2)is added insecurity_and_best_practices.pipe(widget query) andsecurity_deduplicated_merged_copy_pipe.pipe(scheduled copy intosecurity_deduplicated_merged_ds), so evaluations for that control get the correct category and sort order in dashboards and downstream merged data.Reviewed by Cursor Bugbot for commit e745580. Bugbot is set up for automated code reviews on this repo. Configure here.