tickets/SP-2913: new tutorial on SSObject image stamps#160
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
For some of the subsections, the title runs off the table of contents view because they are long. Suggest perhaps removing "of interest" part here (and for 2.1 remove "for a solar system object..." and 3.1 and 4.1 change to "query the obscore table for first visit / all visits" or something like this
Reply via ReviewNB
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
Should this be "store the mpcDesignation" instead of ssObjectId? These IDs are different right? Since you refer tot he mpc ID later, perhaps introduce here what the name is
Reply via ReviewNB
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
Might be good to orient people by noting that this is done using the visit and detector IDs for the visit that was identified in the last query?
Also suggest defining IVOA upon first use (or in intro)
Reply via ReviewNB
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
Suggest making the plots a little larger so that the coordinates don't overlap and are legible
Reply via ReviewNB
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
should SS here be lower case (above it is lower case)? Suggest making all references consistent with the official one. Also looks like there's a typo ( iamge -> image)
Reply via ReviewNB
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1477 @@ | |||
| { | |||
There was a problem hiding this comment.
christinawilliams
left a comment
christinawilliams
left a comment
There was a problem hiding this comment.
All good! Nice job!
2 participants
No description provided.