serviceability: authorize governance instructions via Permission accounts#3977
Open
juan-malbeclabs wants to merge 2 commits into
Open
serviceability: authorize governance instructions via Permission accounts#3977juan-malbeclabs wants to merge 2 commits into
juan-malbeclabs wants to merge 2 commits into
Conversation
…unts Migrate GlobalState (setauthority/setairdrop/setfeatureflags/setversion), GlobalConfig, and foundation/QA allowlist admin instructions to authorize() with the GLOBALSTATE_ADMIN flag. Behavior is preserved via the legacy foundation-allowlist fallback; Permission-account holders are additionally authorized. Correct the stale legacy-mapping table in PERMISSION.md.
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the governance admin instructions to the
authorize()Permission-account system (seesmartcontract/programs/doublezero-serviceability/PERMISSION.md), gated on theGLOBALSTATE_ADMINflag:SetAuthority,SetAirdrop,SetFeatureFlags,SetVersionSetGlobalConfigBehavior is preserved: while
RequirePermissionAccountsis off, the legacy foundation-allowlist check still authorizes; Permission-account holders withGLOBALSTATE_ADMINare additionally accepted. Also corrects the stale legacy-mapping table in PERMISSION.md to matchcheck_legacy_any().Part of the incremental rollout of the Permission system across serviceability (one PR per domain).
Testing Verification
cargo test -p doublezero-serviceability,cargo test -p doublezero_sdk, andmake rust-lintpass.Permission migration series
One of 8 per-domain PRs migrating serviceability instructions to the Permission (
authorize()) system. The branches partition the change set with no overlap and can be reviewed and merged independently (only the CHANGELOG entry conflicts trivially).