sdk: rename permission flag bit 6 from reservation to feed authority#3985
Open
juan-malbeclabs wants to merge 2 commits into
Open
sdk: rename permission flag bit 6 from reservation to feed authority#3985juan-malbeclabs wants to merge 2 commits into
juan-malbeclabs wants to merge 2 commits into
Conversation
The TypeScript and Python serviceability SDKs still named permission-flag bit 6 `PERMISSION_FLAG_RESERVATION`, the pre-rename placeholder. PR #3289 renamed that bit from `RESERVATION` to `FEED_AUTHORITY` in the on-chain program (and the Go SDK followed), repurposing it as the active feed-authority role (`check_legacy_any` maps FEED_AUTHORITY -> feed_authority_pk). The TS/Python SDKs were never updated and drifted. Rename the constant to `PERMISSION_FLAG_FEED_AUTHORITY` (bit value unchanged) so all SDKs match the program's flag names. The constant had no internal references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TypeScript and Python serviceability SDKs named permission-flag bit 6
PERMISSION_FLAG_RESERVATION— the pre-rename placeholder name. This renames it toPERMISSION_FLAG_FEED_AUTHORITY(bit value unchanged,1 << 6) so all SDKs match the on-chain program's flag names.Motive
Bit 6 was originally a reserved slot (
RESERVATION). PR #3289 ("smartcontract: rename reservation to feed authority and remove reservation instructions") renamed that bit toFEED_AUTHORITYin the Rust program and repurposed it as the active feed-authority role —authorize()'scheck_legacy_anymapsFEED_AUTHORITY -> feed_authority_pk, andfeed_authority_pkis used across several processors (multicast subscriber allowlist, access-pass set/close) and folded intoACCESS_PASS_ADMIN. The Go SDK follows the current name (PermissionFlagFeedAuthority = 1 << 6), but the TypeScript and Python SDKs were never updated and drifted to the staleRESERVATIONname.Feed authority is not deprecated —
RESERVATIONis simply the old name that lingered in these two SDKs. This catches them up so a consumer can find theFEED_AUTHORITYrole by its canonical name rather than a misleading "reservation" that maps to no real role.Testing Verification
uv run pytest: 122 passed, 24 skipped). The constant has no internal references, so the rename is isolated; TypeScript type-checking / tests run in CI (bununavailable locally).