fix: apply v1.0.0 release code review fixes#41
Merged
Conversation
lete114
commented
Jun 21, 2026
lete114
commented
Member
- C2: move RNG singleton to instance #rng in Cipher
- I1: wrap decodeURIComponent URIError in textCodec.ts
- I2: replace O(n log n) sentIds sort with O(1) keys().next().value across ipc, rpc, discover
- I3: replace #compressor! assertions with type-safe local variable guards
- I5: add option validation to IPC constructor
- I7: add empty hostname validation to BedrockURL
- I8: replace undefined return with TypeError for unknown Color keys
- I9: add channel validation to IPC.on()
- C2: move RNG singleton to instance #rng in Cipher - I1: wrap decodeURIComponent URIError in textCodec.ts - I2: replace O(n log n) sentIds sort with O(1) keys().next().value across ipc, rpc, discover - I3: replace #compressor! assertions with type-safe local variable guards - I5: add option validation to IPC constructor - I7: add empty hostname validation to BedrockURL - I8: replace undefined return with TypeError for unknown Color keys - I9: add channel validation to IPC.on()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.