Add Egor optimizer wrapper#485
Open
relf wants to merge 26 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 1 1
Lines 147 147
=======================================
Hits 122 122
Misses 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ewu63
reviewed
Jun 16, 2026
ewu63
left a comment
Collaborator
There was a problem hiding this comment.
First things first, let's add egobox to the testing deps of pyproject.toml, so that the test you added may run instead of being skipped for optimizer not available.
ewu63
reviewed
Jun 16, 2026
ewu63
reviewed
Jun 16, 2026
ewu63
reviewed
Jun 21, 2026
ewu63
reviewed
Jun 28, 2026
ewu63
left a comment
Collaborator
There was a problem hiding this comment.
This all looks OK with me, but I will wait for further reviews from @marcomangano and maybe @A-CGray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR integrates the surrogate-based optimizer
Egorfrom the EGObox library.Egor uses bayesian optimization techniques well-suited to find the global optimum of an expansive-to-evaluate black-box function.
Basically, it uses a surrogate model to approximate the objective function and an infill criterion (aka acquisition function) to guide the search for the optimum.
Resolves relf/EGObox#439
Expected time until merged
a few weeks
Type of change
Testing
Egor tests have been added to the pyOptSparse test suite.
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable