Set jfrog to optional and also set python version to be under 3.14#22
Open
tchau-mdsol wants to merge 4 commits into
Open
Set jfrog to optional and also set python version to be under 3.14#22tchau-mdsol wants to merge 4 commits into
tchau-mdsol wants to merge 4 commits into
Conversation
tchau-mdsol
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Poetry configuration to make dependency installation work reliably by (1) adjusting the Artifactory/JFrog repository behavior and (2) constraining the supported Python range to avoid incompatibilities (notably with pyarrow).
Changes:
- Set the
mdsolPoetry source priority tosupplementalso it doesn’t override the default index for all packages. - Restrict supported Python versions to
>=3.13,<3.14. - Regenerate
poetry.lockto reflect the updated Python constraint and resolved dependency set.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Updates Poetry source priority and narrows the supported Python version range to <3.14. |
poetry.lock |
Regenerated lockfile consistent with the updated Python constraint and dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tchau-mdsol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set jfrog to optional and also set python version to be under 3.14
Need to update lock, and change pyproject.toml to use specific python version that works with pyarrrow. Also removed jfrog dependency, since our customers will not have jfrog access.
Here is install working:
python 3.14 does not mix will with pyarrow 19.0.1, which is what is set in the pyproject.toml. Caret (^) means we need a version compatible with 19.0.1 (up to but not including 20). Note the discussion here that pyarrow previous to 22.0 would not be backported in python 3.14. apache/arrow#47438 (comment)
If jfrog is not made supplemental, we get: