Remove logger dependency on libccf#7977
Draft
Copilot wants to merge 6 commits into
Draft
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove logger dependency on libccf.a to resolve circular issues
Remove logger dependency on libccf
Jun 24, 2026
Member
|
@copilot that feels like it's going to lead to duplicated symbols, especially if applications include logger.h too. |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Contributor
Author
Moved the thread ID implementation back out of the header and into a single object compiled into |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7596.
logger.hpulled inget_current_thread_id()fromlibccf.a, creating an implicit circular dependency for libraries such asccfcryptothat are themselves dependencies ofccf.Thread ID ownership
src/threading/thread_ids.cpp, compiled intoccfcrypto, so logger users share a single implementation without linkinglibccf.get_current_thread_id(),set_current_thread_id(), andreset_thread_id_generator().Build graph cleanup
src/enclave/thread_local.cpp.thread_local.cppinto tests, benchmarks, and tools.get_current_thread_idresolution fromccf.Coverage