Add recovery coverage for changed code IDs

[Copilot]

Recovering a ledger should not require the new service to use the same code ID recorded in the defunct ledger. This adds suite-level coverage for recovering with a different app package.

• Recovery scenario

  • Adds recovery_with_new_code_id.
  • Starts a service with samples/apps/logging/logging.
  • Recovers the ledger with js_generic.

• Code ID checks

  • Verifies the original join policy contains the initial package code ID.
  • Verifies the replacement package code ID is absent from the defunct service policy before recovery.
  • Verifies the recovered service trusts the replacement package code ID.

recovery_args = copy.copy(args)
recovery_args.package = "js_generic"

recovered_network.start_in_recovery(
    recovery_args,
    ledger_dir=current_ledger_dir,
    committed_ledger_dirs=committed_ledger_dirs,
)
recovered_network.recover(recovery_args)

[Copilot]

Pull request overview

Adds an end-to-end recovery test to ensure a ledger can be recovered even when the recovering service uses a different application package (and therefore a different code ID / hostData) than the defunct service recorded in its join policy.

Changes:

• Add test_recover_service_with_different_code_id to recover a ledger using a different package and validate join-policy hostData before/after recovery.
• Add a new suite entry (recovery_with_new_code_id) that starts with the C++ logging app and recovers with js_generic, then installs the JS logging app and verifies post-recovery writes.

Custom instructions used:

• .github/copilot-instructions.md
• .github/instructions/reviewing.instructions.md

[achamayou]

@copilot fix code format

[Copilot]

@copilot fix code format

Fixed in 0faa162.