Disable WindowsAppSdkAutoInitialize for windows 10 compatibility#2192
Open
HO-COOH wants to merge 1 commit into
Open
Disable WindowsAppSdkAutoInitialize for windows 10 compatibility#2192HO-COOH wants to merge 1 commit into
HO-COOH wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed compatibility for older windows 10 (especially for windows 10 17763, and possibly other old versions above as well)
Motivation and Context
I found the winui 3 gallery recently (like within one or two months) stopped working recently on my PC with windows 10 17763 (I keep this old version for testing my own winui 3 project). After some digging, I found #2171 breaks it. Previously the app released to store seems to be packaged with that WAP project, so the
WindowsAppSdkAutoInitializeis not needed and not affecting the compatibility (but it IS needed for developing winui 3 gallery directly since it is packaged project).I raised the issue to wasdk repo, but still does not get a true solution
How Has This Been Tested?
Manual.
Screenshots (if appropriate):
Types of changes