chore: Update RBAC Configuration to Reference Role IDs#631
Open
Shreyas-Microsoft wants to merge 1 commit into
Open
chore: Update RBAC Configuration to Reference Role IDs#631Shreyas-Microsoft wants to merge 1 commit into
Shreyas-Microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the infrastructure RBAC role assignment configuration to reference built-in role definition GUIDs (role IDs) instead of role display names, across the primary and custom Bicep templates and the generated ARM JSON.
Changes:
- Replaced several
roleDefinitionIdOrNamevalues from built-in role names to role definition GUIDs ininfra/main.bicep. - Applied the same role-ID changes to the custom deployment template
infra/main_custom.bicep(with one remaining name-based assignment to fix). - Regenerated
infra/main.jsonto reflect the updated Bicep output (template hash and related emitted content updated accordingly).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/main.bicep | Switches multiple role assignments from role names to role definition GUIDs. |
| infra/main_custom.bicep | Mirrors the role-ID updates for custom deployments (one role assignment still uses the role name). |
| infra/main.json | Generated ARM output updated to reflect the Bicep role-ID changes and new template hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| { | ||
| roleDefinitionIdOrName: 'Storage Queue Data Contributor' | ||
| roleDefinitionIdOrName: '974c5e8b-45b9-4653-ba55-5f855dd0fb88' //'Storage Queue Data Contributor' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update RBAC Configuration to Reference Role IDs
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information