Skip to content

chore: Update RBAC Configuration to Reference Role IDs#631

Open
Shreyas-Microsoft wants to merge 1 commit into
microsoft:devfrom
Shreyas-Microsoft:psl-use-rbac-ids
Open

chore: Update RBAC Configuration to Reference Role IDs#631
Shreyas-Microsoft wants to merge 1 commit into
microsoft:devfrom
Shreyas-Microsoft:psl-use-rbac-ids

Conversation

@Shreyas-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

Update RBAC Configuration to Reference Role IDs

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the infrastructure RBAC role assignment configuration to reference built-in role definition GUIDs (role IDs) instead of role display names, across the primary and custom Bicep templates and the generated ARM JSON.

Changes:

  • Replaced several roleDefinitionIdOrName values from built-in role names to role definition GUIDs in infra/main.bicep.
  • Applied the same role-ID changes to the custom deployment template infra/main_custom.bicep (with one remaining name-based assignment to fix).
  • Regenerated infra/main.json to reflect the updated Bicep output (template hash and related emitted content updated accordingly).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
infra/main.bicep Switches multiple role assignments from role names to role definition GUIDs.
infra/main_custom.bicep Mirrors the role-ID updates for custom deployments (one role assignment still uses the role name).
infra/main.json Generated ARM output updated to reflect the Bicep role-ID changes and new template hash.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main_custom.bicep
}
{
roleDefinitionIdOrName: 'Storage Queue Data Contributor'
roleDefinitionIdOrName: '974c5e8b-45b9-4653-ba55-5f855dd0fb88' //'Storage Queue Data Contributor'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants