apply org.openrewrite.java.migrate.JavaBestPractices

[dsgrieve]

Ran openrewrite JavaBestPractices, e.g.,

./mvnw -U org.openrewrite.maven:rewrite-maven-plugin:run --define rewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE --define rewrite.activeRecipes=org.openrewrite.java.migrate.JavaBestPractices --define rewrite.exportDatatables=true

JavaBestPractices bumps the version to 25.
In UnifiedDiariazer, GC_CAUSE was ambiguous (both a Token and a SupportedFlags) so I removed the static import and qualified the SupportedFlags.

[dsgrieve]

@microsoft-github-policy-service agree

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[karianna]

@dsgrieve This breaks the Java 11+ matrix build, are you able to adjust the PR to add Java 25 without taking away the others?

[dsgrieve]

@dsgrieve This breaks the Java 11+ matrix build, are you able to adjust the PR to add Java 25 without taking away the others?
I totally forgot about the matrix build.