Skip to content

Apple: Fix _platform_strlen crashes inside getSystemProxyForUri#997

Open
lawrencewuskyboxlabs wants to merge 1 commit into
microsoft:mainfrom
lawrencewuskyboxlabs:utf8_strlen_crash
Open

Apple: Fix _platform_strlen crashes inside getSystemProxyForUri#997
lawrencewuskyboxlabs wants to merge 1 commit into
microsoft:mainfrom
lawrencewuskyboxlabs:utf8_strlen_crash

Conversation

@lawrencewuskyboxlabs

Copy link
Copy Markdown

I've seen some crashes on iOS where a _platform_strlen error is thrown in the basic_string constructor during getSystemProxyForUri. In general, since UTF8String returns a char pointer, the three locations where it's used should check that the pointer is valid before using it to create a string.

@lawrencewuskyboxlabs

Copy link
Copy Markdown
Author

@lawrencewuskyboxlabs please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant