Skip to content

Fix STL wait-timer strand: restore pre-#975 backend (close #973) #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgomez391 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix STL wait-timer strand: restore pre-#975 backend (close #973) #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83ffb4c
Fix STL wait-timer strand: restore pre-#975 backend (close #973)
raulalbertog Jun 23, 2026
77e25d8
Add single-port delayed-callback strand regression test
raulalbertog Jun 23, 2026
8c802e3
CI: run the single-port poll-strand test in the Linux ctest lane
raulalbertog Jun 23, 2026
3024234
CI: select TaskQueue regression tests by ctest label, not by name
raulalbertog Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions Build/libHttpClient.Linux/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,5 +313,67 @@ add_test(
NAME taskqueue-starvation-linux
COMMAND "TaskQueueStarvationTests.Linux"
)
# Label so CI can run every TaskQueue regression test by label (-L taskqueue)
# without having to opt each new test in by name.
set_tests_properties(
taskqueue-starvation-linux
PROPERTIES
LABELS "taskqueue"
)

#################################################
### TaskQueue single-port poll strand test ###
#################################################
# Standalone regression guard for the single-port delayed-callback strand bug.
# Exercises the STL WaitTimer backend that the Windows test lanes cannot reach.
# Uses only the public XTaskQueue API + the standard library, so it just links
# the libHttpClient.Linux target.
add_executable(
"SingleQueuePollStrandTests.Linux"
"${PATH_TO_ROOT}/Tests/TaskQueueStarvation/SingleQueuePollStrandRepro.cpp"
)

target_include_directories(
"SingleQueuePollStrandTests.Linux"
PRIVATE
"${COMMON_INCLUDE_DIRS}"
"${LINUX_INCLUDE_DIRS}"
"${PATH_TO_ROOT}/Tests/Shared"
)

target_link_libraries(
"SingleQueuePollStrandTests.Linux"
PRIVATE
"${PROJECT_NAME}"
Threads::Threads
${CMAKE_DL_LIBS}
)

if (NOT BUILD_SHARED_LIBS)
target_link_libraries(
"SingleQueuePollStrandTests.Linux"
PRIVATE
"${LIBCURL_BINARY_PATH}"
"${LIBSSL_BINARY_PATH}"
"${LIBCRYPTO_BINARY_PATH}"
)
endif()

target_set_flags(
"SingleQueuePollStrandTests.Linux"
"${FLAGS}"
"${FLAGS_DEBUG}"
"${FLAGS_RELEASE}"
)

add_test(
NAME taskqueue-poll-strand-linux
COMMAND "SingleQueuePollStrandTests.Linux"
)
set_tests_properties(
taskqueue-poll-strand-linux
PROPERTIES
LABELS "taskqueue"
)

export(TARGETS ${PROJECT_NAME} FILE ${PROJECT_NAME}Config.cmake)
Loading