Fix register_from_C AttributeError in joblib workers#2264
Open
Whning0513 wants to merge 1 commit into
Open
Conversation
register_from_C is called from joblib worker processes, which are forked from the main process. In freshly spawned workers, the global config object C is a plain Config instance (not QlibConfig), so C.registered raises AttributeError because Config.__getattr__ falls through to raise when the key isn't in _config dict. The fix changes C.registered to getattr(C, 'registered', False), which returns False for plain Config instances where the attribute doesn't exist. This ensures the registration logic runs in worker processes rather than silently crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix register_from_C AttributeError in joblib workers