Fix no-op sort_index() in SeriesDFilter._toTimestamp#2269
Open
Whning0513 wants to merge 1 commit into
Open
Conversation
`timestamp_series.sort_index()` was called without reassignment or inplace=True, making it a silent no-op. The _toTimestamp state machine iterates over `timestamp_series.items()` and depends on the index being sorted to correctly detect transitions between contiguous True/False ranges. Without the sort, adjacent timestamps in arbitrary insertion order can produce spurious split intervals or merged ones, causing ExpressionDFilter and NameDFilter to yield incorrect instrument coverage intervals. This went unnoticed because ExpressionDFilter typically operates on calendar-ordered data from DatasetD, meaning the series often arrives pre-sorted by coincidence. Explicitly reassigning the sorted result guarantees correctness regardless of input order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix no-op sort_index() in SeriesDFilter._toTimestamp