Skip to content

fix(settings): prevent fps input from resetting (@Rajparikh18) #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rajparikh18 wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −1
Open

fix(settings): prevent fps input from resetting (@Rajparikh18) #8130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c1d65a
fix(settings): prevent fps input from resetting (@Rajparikh18)
Rajparikh18 Jun 17, 2026
0727635
fix(settings): handle native fps mode correctly (@Rajparikh18)
Rajparikh18 Jun 18, 2026
d54621e
Merge branch 'master' into fix/fps-input-reset
Rajparikh18 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/src/ts/components/pages/settings/custom-setting/AnimationFpsLimit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function AnimationFpsLimit(): JSXElement {
const savedIndicator = useSavedIndicator();
const form = createForm(() => ({
defaultValues: {
fpsLimit: "",
fpsLimit: getfpsLimit() === 1000 ? "" : String(getfpsLimit()),
},
Comment thread
Rajparikh18 marked this conversation as resolved.
onSubmit: ({ value }) => {
const val = parseFloat(String(value.fpsLimit));
Expand Down Expand Up @@ -54,6 +54,9 @@ export function AnimationFpsLimit(): JSXElement {
name="fpsLimit"
validators={{
onChange: ({ value }) => {
if (value === "") {
return;
}
const val = parseFloat(String(value));
if (isNaN(val)) {
return "Must be a number";
Expand Down
Loading