config: make cot_product optional#810
Open
jcristau wants to merge 1 commit into
Open
Conversation
jcristau
commented
Jul 8, 2026
jcristau
commented
Contributor
- set the default cot_product to None
- when cot_product is None, apply_product_config resolves by-cot-product mappings to None as well
- check_config allows str values for cot_product despite the None default, and checks that verify_chain_of_trust is off when cot_product is not set, since chain of trust verification relies on cot_product-specific config
- set the default cot_product to None - when cot_product is None, apply_product_config resolves by-cot-product mappings to None as well - check_config allows str values for cot_product despite the None default, and checks that verify_chain_of_trust is off when cot_product is not set, since chain of trust verification relies on cot_product-specific config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.