Skip to content

Remove/directorymanager 11.0#1241

Open
ivan-zamkovyi-nwx wants to merge 6 commits into
devfrom
remove/directorymanager-11.0
Open

Remove/directorymanager 11.0#1241
ivan-zamkovyi-nwx wants to merge 6 commits into
devfrom
remove/directorymanager-11.0

Conversation

@ivan-zamkovyi-nwx

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Code Review

Scope reviewed: config/routing/build-affecting changes only (per instructions, documentation content and style were not reviewed). This PR removes Directory Manager 11.0 (999 files: the docs/directorymanager/11.0/ tree, static/images/directorymanager/11.0/, sidebars/directorymanager/11.0.js, and a 6-line edit to src/config/products.js). No workflow or script files were changed.

No blocking issues found. The removal is clean and consistent:

  • src/config/products.js — Only the 11.0 version block is removed. It was isLatest: false, and 11.1 remains isLatest: true with defaultVersion: "11.1", so there is no dangling latest/default reference.
  • sidebars/directorymanager/11.0.js — Deleted; 11.1.js remains and is the only sidebar referenced by products.js.
  • Redirects (docusaurus.config.js client-redirects) — Fully derived from products.js / getLatestVersionUrlMap(); nothing is hardcoded to 11.0. Directory Manager still qualifies for a base-to-latest redirect (/docs/directorymanager to /docs/directorymanager/11_1), so routing stays valid.
  • Images — All 11.0 images are removed, and no surviving file references images/directorymanager/11.0. No cross-product image sharing was broken.
  • Build integrity — With onBrokenLinks: "throw", I checked for internal links to deleted 11.0 pages/images. None found in retained files, so the build should not break on broken links.

Minor (non-blocking, does not break the build):

Three retained files still contain outbound links to now-removed directorymanager/11.0 URLs. These are absolute external URLs (https://docs.netwrix.com/..., https://releases.netwrix.com/...), which Docusaurus does not validate against onBrokenLinks, so they will not fail the build — but they will become dead links after deploy:

  • docs/directorymanager/11.1/admincenter/service/securityservice/signkeyutility.md line 34 (releases.netwrix.com Signing-Key-Utility 11.0 zip)
  • docs/kb/directorymanager/configuration-and-integration/how-to-add-message-approvers-in-group-properties-in-groupid-portal.md line 99 (.../directorymanager/11_0/signin/service/mobileservice/design/objectproperties)
  • docs/kb/directorymanager/reporting-export-and-data-management/best-practices-for-controlling-changes-to-group-membership.md lines 96, 99, 103 (several .../directorymanager/11_0/... links)

Consider repointing these to the 11.1 equivalents. This is a content-adjacent cleanup, not a code correctness defect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant