fix: cast boardUsers to string#8066
Open
grnd-alt wants to merge 2 commits into
Open
Conversation
Signed-off-by: grnd-alt <git@belakkaf.net>
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable33 |
grnd-alt
commented
Jun 15, 2026
| $card = $this->cardMapper->find($cardId); | ||
| $boardId = $this->cardMapper->findBoardId($cardId); | ||
| $boardUsers = array_keys($this->permissionService->findUsers($boardId, true)); | ||
| $boardUsers = array_map(fn (string|int $userId) => (string)$userId, array_keys($this->permissionService->findUsers($boardId, true))); |
Member
Author
There was a problem hiding this comment.
php converts array keys, that are inserted as strings, to int if possible, so the later in_array fails if the user_id passed is a string but boardUsers contains ints for numeric userIds
Contributor
|
🐢 Performance warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.