Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/dev/openfeature/sdk/HookSupport.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ public void setHooks(

private static void addFilteredHooks(
List<Pair<Hook, HookContext>> dest, Collection<Hook> source, FlagValueType type) {
if (source.isEmpty()) {
return;
}
for (Hook hook : source) {
if (hook.supportsFlagValueType(type)) {
dest.add(Pair.of(hook, null));
Expand Down
32 changes: 32 additions & 0 deletions src/test/java/dev/openfeature/sdk/HookSupportTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentLinkedQueue;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
Expand Down Expand Up @@ -161,6 +162,37 @@ void shouldOrderHooksBySource() {
.containsExactly(providerHook, optionHook, clientHook, apiHook);
}

@Test
@DisplayName("empty ConcurrentLinkedQueue sources produce no hooks")
void emptyQueueSourcesProduceNoHooks() {
var hookSupportData = new HookSupportData();
hookSupport.setHooks(
hookSupportData,
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>(),
FlagValueType.STRING);
assertThat(hookSupportData.getHooks()).isEmpty();
}

@Test
@DisplayName("non-empty ConcurrentLinkedQueue source is not skipped")
void nonEmptyQueueSourceIsNotSkipped() {
Hook<?> hook = mockGenericHook();
var queue = new ConcurrentLinkedQueue<Hook>();
queue.add(hook);
var hookSupportData = new HookSupportData();
hookSupport.setHooks(
hookSupportData,
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>(),
queue,
new ConcurrentLinkedQueue<>(),
FlagValueType.STRING);
assertThat(hookSupportData.getHooks()).extracting(Pair::getKey).containsExactly(hook);
}

@Test
void hookThatReturnsTheGivenContext_doesNotResultInAStackOverflow() {
var hookSupportData = new HookSupportData();
Expand Down
Loading