chore: resolve open dependabot security alerts#1402
Conversation
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDependency Resolution Pins
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses Dependabot security alerts in the site’s Yarn (v4) dependency graph by re-resolving the lockfile and adding targeted resolutions overrides to bump vulnerable transitive packages while avoiding known-breaking upgrades (notably keeping gray-matter on js-yaml v3).
Changes:
- Updated
yarn.lockto pull patched transitive versions (e.g.,form-data@4.0.6,tar@7.5.16,launch-editor@2.14.1,@babel/core@7.29.7,markdown-it@14.2.0,http-proxy-middleware@3.0.7,js-yaml@4.2.0). - Added/adjusted scoped Yarn
resolutionsentries to force specific dependency subtrees onto patched versions while avoiding incompatible majors (e.g.,js-yamlv4 only for v4 consumers).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Re-resolves dependency tree to patched versions, including major transitive bumps where required (e.g., http-proxy-middleware to v3). |
| package.json | Adds scoped resolutions to force patched transitive versions (including js-yaml, markdown-it, http-proxy-middleware). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "js-yaml@^4.1.0": "^4.2.0", | ||
| "markdownlint-cli2/js-yaml": "^4.2.0", | ||
| "markdownlint/markdown-it": "^14.2.0", | ||
| "webpack-dev-server/http-proxy-middleware": "^3.0.6", |
Summary
Resolved 7 of 8 open Dependabot security alerts by bumping vulnerable transitive dependencies. Four were fixed by a lockfile-only re-resolution (their parents' ranges already permit the patched versions); three required scoped Yarn
resolutions.Dependabot Alerts Resolved
form-datahttp-proxy-middlewarewebpack-dev-server/http-proxy-middleware)markdown-itmarkdownlint/markdown-it)tarlaunch-editorjs-yamljs-yaml@^4.1.0@babel/coreNotes
js-yamlresolution is intentionally scoped to the^4.1.0range (not global).gray-matter@4.0.3depends onjs-yaml@^3.13.1and calls thesafeLoadAPI that was removed in js-yaml 4; a global bump would break Docusaurus frontmatter parsing at build time. The scoped resolution keeps gray-matter on js-yaml 3.14.2 while patching the 4.x consumers.webpack: 5.104.1pin is retained sowebpackbar's ProgressPlugin keeps working.http-proxy-middlewareis dev-server-only (not in the production build). The only patched line is 3.x;yarn docusaurus startwas verified to boot cleanly with 3.0.7.Unresolvable
tsup(low): no patched version is available yet (first_patched_versionis null), so this alert is left open.Verification
yarn build(full Docusaurus production build): succeeds, both Server and Client compiled.yarn lint:md(markdownlint-cli2, the js-yaml/markdown-it consumer): 0 errors.yarn install --immutable: passes (lockfile consistent).yarn docusaurus start: dev server boots with http-proxy-middleware 3.0.7.yarn typecheckerrors (missing image type declarations and aC++dataset entry) are unrelated to these changes and reproduce on a cleanorigin/main.