[codex] Add AWS Bedrock provider authentication#289
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4af7fdf180
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jliccini
left a comment
There was a problem hiding this comment.
Inline review of the default Bedrock endpoint.
jliccini
left a comment
There was a problem hiding this comment.
Approving but noting that the URL thing Codex found might be important. I am not a Bedrock expert but the Ruby lgtm
jliccini
left a comment
There was a problem hiding this comment.
Ruby truthiness and optional-value validation review.
jliccini
left a comment
There was a problem hiding this comment.
Ruby public-type and exception-contract review.
Summary
OpenAI::Providers.bedrockprovider for Amazon Bedrock's OpenAI-compatible API~/.aws/credentialsWhy
The Ruby SDK did not have a supported provider-authentication path for AWS Bedrock, so applications could not use their normal AWS credentials file or runtime credential chain with the standard OpenAI client. This brings Ruby in line with the provider architecture used by the Node and Python SDKs.
Linear: SDK-78
User impact
Ruby users can now construct the normal client with
OpenAI::Providers.bedrock(...)and use AWS environment credentials, shared credentials/config files, named profiles, SSO or assume-role profiles, workload identities, explicit static credentials, or refreshable providers. AWS authentication loadsaws-sdk-coreas an optional dependency; bearer authentication does not require it.Provider authentication is applied immediately before every transport attempt, so retries receive fresh credentials and a fresh signature over the exact serialized body and retry headers.
Validation
git diff --checkpassesThe full generated resource suite requires the local Prism mock server on
localhost:4010; without it, those tests stop on expected connection errors. CI provisions that dependency.