feat(proto): Add p2,98,25,75; refactor tests#181
Open
devsjc wants to merge 1 commit into
Open
Conversation
Benchmark ResultsBenchmark resultsBenchmark vs base branch |
3 tasks
3 tasks
| (buf.validate.field).map.max_pairs = 20, | ||
| (buf.validate.field).map.keys = { | ||
| string: {in: ["p10", "p90"]} | ||
| string: {in: ["p10", "p90", "p2", "p98", "p25", "p75"]} |
Contributor
There was a problem hiding this comment.
could you order this?
| DROP COLUMN p2_sip, | ||
| DROP COLUMN p98_sip, | ||
| DROP COLUMN p25_sip, | ||
| DROP COLUMN p75_sip; |
Contributor
There was a problem hiding this comment.
perhaps order these p2, p25, p75, p98, just to make it easier to read.
I know it doesnt make any different in the sql tables
| GeometryUuid: uuid.MustParse(req.LocationUuid), | ||
| SourceTypeID: int16(req.EnergySource.Number()), | ||
| AtTimestampUtc: pgtype.Timestamp{Time: req.ValidFromUtc.AsTime(), Valid: true}, | ||
| AtTimestampUtc: pgtype.Timestamp{Time: validFrom, Valid: true}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 4 more p-levels to the predicted generation values table. These cost nothing storage-wise if they are unused. Also refactors the test suite a little bit.
Contribution Checklist
make lintwith your changes locally?make testwith your changes locally?Warning
PRs may be closed if all the above boxes are not checked.