Highlight small players: on by default

[Zixer1]

Description:

Follow-up to #4525: the small-player highlight now defaults to on for everyone. Players can still turn it off in Settings — only the default flips.

One-line change in UserSettings.highlightSmallPlayers() (default false → true), plus the matching test updates.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ef0cd92-9ce0-428d-bf04-2d3527f114c6

📥 Commits

Reviewing files that changed from the base of the PR and between d766913 and a409d9f.

📒 Files selected for processing (2)

• src/core/game/UserSettings.ts
• tests/UserSettings.test.ts

---

Walkthrough

highlightSmallPlayers() now defaults to enabled when unset or invalid. Tests update the default, toggle behavior, and shared-state expectations.

Changes

Highlight small players setting

Layer / File(s)	Summary
Default behavior and validation src/core/game/UserSettings.ts, tests/UserSettings.test.ts	The setting defaults to true; tests verify the new default, toggle sequence, and shared cached state.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4525: Changes the same “Highlight small players” setting semantics.

Poem

Small players now shine bright,
Enabled by default light.
Toggle off, then on again,
Shared settings follow the same refrain.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: small players are now highlighted on by default.
Description check	✅ Passed	The description accurately describes the default flip and the matching test updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}