Skip to content

OCPBUGS-84517: Remove stale openshift-marketplace terminationMessagePolicy exemption#31357

Closed
jrangelramos wants to merge 1 commit into
openshift:release-4.23from
jrangelramos:OCPBUGS-84517-4.23
Closed

OCPBUGS-84517: Remove stale openshift-marketplace terminationMessagePolicy exemption#31357
jrangelramos wants to merge 1 commit into
openshift:release-4.23from
jrangelramos:OCPBUGS-84517-4.23

Conversation

@jrangelramos

@jrangelramos jrangelramos commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

Remove the openshift-marketplace namespace exemption from the
terminationMessagePolicy monitor test.

Backport of #31355 to release-4.23.

Background

The monitor test [sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError was flaking
because osd-patch-subscription-source CronJob pods lacked
terminationMessagePolicy: FallbackToLogsOnError.

A temporary exemption was added, but it incorrectly exempted
pods/podman rather than the actual violating pods. The root cause has
been fixed upstream by adding terminationMessagePolicy: FallbackToLogsOnError to the CronJob containers.

Dependencies

This PR depends on the upstream fix:

Bug: OCPBUGS-84517

@jrangelramos @claude
OCPBUGS-84517: Remove stale openshift-marketplace terminationMessageP…
c7c1254 
…olicy exemption

The upstream fix in managed-cluster-config added terminationMessagePolicy:
FallbackToLogsOnError to the osd-patch-subscription-source CronJob. Remove
the now-unnecessary exemption.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 30, 2026

Copy link
Copy Markdown

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is invalid:

  • expected the bug to target the "4.23.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-84517 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the openshift-marketplace namespace exemption from the
terminationMessagePolicy monitor test.

Backport of #31355 to release-4.23.

Background

The monitor test [sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError was flaking
because osd-patch-subscription-source CronJob pods lacked
terminationMessagePolicy: FallbackToLogsOnError.

A temporary exemption was added, but it incorrectly exempted
pods/podman rather than the actual violating pods. The root cause has
been fixed upstream by adding terminationMessagePolicy: FallbackToLogsOnError to the CronJob containers.

Dependencies

This PR depends on the upstream fix:

Bug: OCPBUGS-84517

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a78700aa-46e2-4147-bae6-40f0d3ad97b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from deads2k and sjenning June 30, 2026 17:40
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jrangelramos

jrangelramos commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jun 30, 2026

Copy link
Copy Markdown

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is invalid:

  • expected the bug to target either version "4.23." or "openshift-4.23.", but it targets "5.0.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-84517 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jrangelramos

jrangelramos commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/close target branch is fast-forward from main.

@openshift-ci-robot

openshift-ci-robot commented Jul 3, 2026

Copy link
Copy Markdown

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the openshift-marketplace namespace exemption from the
terminationMessagePolicy monitor test.

Backport of #31355 to release-4.23.

Background

The monitor test [sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError was flaking
because osd-patch-subscription-source CronJob pods lacked
terminationMessagePolicy: FallbackToLogsOnError.

A temporary exemption was added, but it incorrectly exempted
pods/podman rather than the actual violating pods. The root cause has
been fixed upstream by adding terminationMessagePolicy: FallbackToLogsOnError to the CronJob containers.

Dependencies

This PR depends on the upstream fix:

Bug: OCPBUGS-84517

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k
@sjenning sjenning Awaiting requested review from sjenning

Assignees

No one assigned

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrangelramos @openshift-ci-robot