Allow verify directories to already exist#81539
Conversation
|
/testwith openshift/api/master/verify-client-go openshift/api#2813 |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThis change updates the openshift/api CI configuration so two verify jobs only clone repositories when the destination directories are absent. ChangesClone guard updates
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/api/openshift-api-master.yaml`:
- Around line 86-88: The clone guard in the script block is backwards: the `git
clone` step should run when `$dir` is missing, not when it already exists.
Update the conditional around the `git clone
https://github.com/openshift/client-go` command so normal CI populates an
empty/missing checkout, and existing non-empty directories are left alone; use
the `$dir` check in that same shell block to invert the logic cleanly.
- Around line 104-109: The clone conditions in the integration setup are
inverted and only run when the target directories already exist. Update the
shell checks around the hypershift and openshift-client-go git clone commands so
they only execute when the corresponding directories are absent, using the
existing $dir-based paths in the script. Keep the same guard pattern for both
clone blocks so fresh CI runs populate the checkouts and existing workspaces are
not overwritten.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 01848b5f-8b33-420c-b9f3-5f0baf95971a
📒 Files selected for processing (1)
ci-operator/config/openshift/api/openshift-api-master.yaml
Allow the hypershift and client-fo directories to already exist. This means that when you use `/testwith`, which clones the working code out from another PR, we can leverage that code rather than the main branch content.
JoelSpeed
force-pushed
the
allow-local-override-api-verify
branch
from
582ac2f to
ca31e8e
Compare
|
/testwith openshift/api/master/verify-client-go openshift/api#2813 |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack The test with is more representative |
|
@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 15244dd
into
openshift:main
2 participants
Allow the hypershift and client-fo directories to already exist. This means that when you use
/testwith, which clones the working code out from another PR, we can leverage that code rather than the main branch content.Summary by CodeRabbit
Adjusted the OpenShift API CI release verification flow (
ci-operator/config/openshift/api/openshift-api-master.yaml) so theverify-client-goandverify-hypershift-integrationsteps can run when their working directories already exist (e.g., during/testwithwhere code is pre-cloned from another PR). The steps now conditionallygit cloneopenshift/client-goandopenshift/hypershiftonly if the corresponding target directories are missing, preventing clones from overwriting or replacing existing checked-out content; the subsequent vendoring/modification/testing commands remain unchanged.